[ci] build + release w/ go 1.12 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 68.48% 68.48%
=======================================
Files 26 26
Lines 1869 1869
=======================================
Hits 1280 1280
Misses 489 489
Partials 100 100Continue to review full report at Codecov.
|
mway
approved these changes
Apr 4, 2019
mway
reviewed
Apr 4, 2019
Makefile
Outdated
| @@ -44,9 +45,11 @@ metalint_check := .ci/metalint.sh | |||
| metalint_config := .metalinter.json | |||
| metalint_exclude := .excludemetalint | |||
| gopath_prefix := $(GOPATH)/src | |||
| gopath_bin_path := $(GOPATH)/bin | |||
There was a problem hiding this comment.
note: i'd probably do something like this:
GOBIN ?= $(GOPATH)/binand then use $(GOBIN) instead of $(gopath_bin_path) below. this has the advantage of respecting any existing $GOBIN value in the environment.
schallert
force-pushed
the
schallert/go_1_12
branch
from
5c2fa0f to
7d89595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.