[m3msg] Specialize messageWriter acker map #4113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| delete(a.ackMap, meta.metadataKey) | ||
| a.Unlock() | ||
| a.mtx.Lock() | ||
| defer a.mtx.Unlock() |
There was a problem hiding this comment.
Not opposed to the defer here but the old way read just as well? Also just for internal consistency within the class--the other methods also don't defer, so could keep it the same here.
Not hugely important though.
| defer w.RUnlock() | ||
| w.m.messageConsumeLatency.Record(time.Duration(w.nowFn().UnixNano() - expectedProcessNanos)) | ||
| w.m.messageAcked.Inc(1) | ||
| m := w.m |
There was a problem hiding this comment.
Hmm w.m is a pointer--do we not need to keep holding the lock when use it?
I guess w.m.messageConsumeLatency might be safe.
Dunno maybe we should make the metrics type handle its own locking instead.
There was a problem hiding this comment.
this metrics thing is very awkward, might as well fix it now vs deferring
There was a problem hiding this comment.
w.m is replaced wholesale when consumers are changed (and so are metric labels)
andrewmains12
approved these changes
May 5, 2022
andrewmains12
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There's no need for shard in metadataKey for internal messageWriter ack map, as it's always the same shard.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: