[dbnode] Fixing entry leak in series ref resolver #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rallen090
approved these changes
Dec 8, 2021
rallen090
reviewed
Dec 8, 2021
| @@ -2040,6 +2040,8 @@ func TestSeriesRefResolver(t *testing.T) { | |||
| require.NoError(t, err) | |||
| err = resolverEntry.ReleaseRef() | |||
| require.NoError(t, err) | |||
| entry := seriesRef.(*Entry) | |||
| require.Zero(t, entry.ReaderWriterCount()) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
SeriesRefResolvermight leak entries if they are not already inserted.This PR decrements reader writer count when resolving new entry from the resolver so the entry could be purged later.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: