[aggregator] Add support for default configuration #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds sane defaults that can be used for spinning up the aggregator. Allows clients to greatly simplify the provided config and only specify configuration options they need. Additionally makes spin up of aggregator for local development and integration tests easier. Also, does some minor cleanup for aggregator in test harness.
Codecov Report
@@ Coverage Diff @@
## master #3856 +/- ##
======================================
Coverage 56.8% 56.8%
======================================
Files 552 552
Lines 63272 63272
======================================
Hits 35980 35980
Misses 24087 24087
Partials 3205 3205
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
rallen090
reviewed
Oct 20, 2021
|
|
||
| return cfg, nil | ||
| } | ||
|
|
||
| func updateAggregatorFilepaths(cfg config.Configuration) (config.Configuration, []string, error) { | ||
| tmpDirs := make([]string, 0, 1) | ||
| if cfg.KVClient.Etcd != nil && cfg.KVClient.Etcd.CacheDir == "*" { |
There was a problem hiding this comment.
Is this * something we need to keep around?
There was a problem hiding this comment.
Nah, that's an old convention that I'm killing off here. Good question though
rallen090
approved these changes
Oct 20, 2021
soundvibe
pushed a commit
that referenced
this pull request
Oct 26, 2021
* master: Remove unused message-read-error metric (#3869) Add p75/p25 as aggregation options (#3867) [aggregator] track dirty values to consume instead of scanning all within buffer past (#3847) [rules] Correctly match rollup tags for excludeBy operations (#3865) [dbnode] Create empty warm index fileset (#3859) [aggregator] Allow wait during tick to be interrupted on close (#3861) [aggregator] Add support for default configuration (#3856) [dbnode] Add WriteAttempt integration test index helper method (#3860) [tools] Allow reading all the shards in the directory in read_data_files (#3857) [tests] Add test for in-process aggregator writes [tools] Add annotation_checker tool (#3854) [tests] Convert docker-integration-tests/simple/test.sh to in-process test (#3850) [documentation] Update rollup rules documentation to provide an example of aggregating gauges (#3852)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit adds sane defaults that can be used for spinning
up the aggregator. Allows clients to greatly simplify the
provided config and only specify configuration options they need.
Additionally makes spin up of aggregator for local development
and integration tests easier. Also, does some minor cleanup
for aggregator in test harness.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: