Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[downsampler] Flesh comments in metrics_appender.go #3803

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Conversation

wesleyk
Copy link
Collaborator

@wesleyk wesleyk commented Oct 1, 2021

What this PR does / why we need it:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@wesleyk wesleyk enabled auto-merge (squash) October 1, 2021 20:08
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #3803 (ddeddc4) into master (ddeddc4) will not change coverage.
The diff coverage is n/a.

❗ Current head ddeddc4 differs from pull request most recent head 523c46e. Consider uploading reports for the commit 523c46e to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3803   +/-   ##
======================================
  Coverage    56.8%   56.8%           
======================================
  Files         552     552           
  Lines       63077   63077           
======================================
  Hits        35888   35888           
  Misses      23996   23996           
  Partials     3193    3193           
Flag Coverage Δ
aggregator 63.4% <0.0%> (ø)
cluster ∅ <0.0%> (∅)
collector 58.4% <0.0%> (ø)
dbnode 60.5% <0.0%> (ø)
m3em 46.4% <0.0%> (ø)
metrics 19.7% <0.0%> (ø)
msg 74.4% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddeddc4...523c46e. Read the comment docs.

@wesleyk wesleyk merged commit 5b8f316 into master Oct 1, 2021
@wesleyk wesleyk deleted the wesley-doc branch October 1, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants