Optionally disable m3msg consumer metric scope #3802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For large m3msg deployments the number of consumers can add a lot of cardinality to the metrics. Now users can disable the "consumer" label via the config option.
rallen090
reviewed
Oct 1, 2021
src/msg/producer/config/writer.go
Outdated
| @@ -107,6 +107,9 @@ type WriterConfiguration struct { | |||
| // IgnoreCutoffCutover allows producing writes ignoring cutoff/cutover timestamp. | |||
| // Must be in sync with AggregatorConfiguration.WritesIgnoreCutoffCutover. | |||
| IgnoreCutoffCutover bool `yaml:"ignoreCutoffCutover"` | |||
| // WithoutConsumerScope drops the consumer tag from the metrics. For large m3msg deployments the consumer tag can | |||
| // add a lot of cardinality to the metrics. | |||
| WithoutConsumerScope bool `ymal:"withoutConsumerScope"` | |||
There was a problem hiding this comment.
lol how did the linter not catch this (at least locally)
rallen090
approved these changes
Oct 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #3802 +/- ##
========================================
- Coverage 57.0% 56.8% -0.3%
========================================
Files 552 552
Lines 63363 63077 -286
========================================
- Hits 36180 35880 -300
- Misses 23983 23998 +15
+ Partials 3200 3199 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Antanukas
pushed a commit
that referenced
this pull request
Oct 5, 2021
For large m3msg deployments the number of consumers can add a lot of cardinality to the metrics. Now users can disable the "consumer" label via the config option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For large m3msg deployments the number of consumers can add a lot of
cardinality to the metrics. Now users can disable the "consumer" label
via the config option.
What this PR does / why we need it:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: