Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Add Env and Zone while handling placements with resources.Coordinator #3796

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

fishie9
Copy link
Collaborator

@fishie9 fishie9 commented Sep 30, 2021

What this PR does / why we need it:

This PR adds Zone and Env to the PlacementOpts for resources.Coordinator. We can now specify the zone and environment of the placement while initializing it.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Siyu Yang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #3796 (0ac5b42) into master (b36cbb0) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3796     +/-   ##
========================================
- Coverage    56.9%   56.8%   -0.1%     
========================================
  Files         552     552             
  Lines       63064   63064             
========================================
- Hits        35890   35862     -28     
- Misses      23984   24005     +21     
- Partials     3190    3197      +7     
Flag Coverage Δ
aggregator 63.4% <ø> (+<0.1%) ⬆️
cluster ∅ <ø> (∅)
collector 58.4% <ø> (ø)
dbnode 60.4% <ø> (-0.1%) ⬇️
m3em 46.4% <ø> (ø)
metrics 19.7% <ø> (ø)
msg 74.2% <ø> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b36cbb0...0ac5b42. Read the comment docs.

@fishie9 fishie9 requested a review from nbroyles September 30, 2021 14:36
@fishie9 fishie9 changed the title [tests] Add Env and Zone while handling placement with resources.Coordinator [tests] Add Env and Zone while handling placements with resources.Coordinator Sep 30, 2021
@fishie9 fishie9 merged commit ada7ea2 into master Sep 30, 2021
@fishie9 fishie9 deleted the siyu/placement branch September 30, 2021 18:14
Antanukas pushed a commit that referenced this pull request Oct 5, 2021
…3796)

This commit adds Zone and Env to the PlacementOptions for resources.Coordinator. We can now specify the zone and environment for a placement while initializing it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants