-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Add In-Process Aggregator (Start Only) #3795
Conversation
Siyu Yang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
8b2f151
to
7c36a71
Compare
Codecov Report
@@ Coverage Diff @@
## master #3795 +/- ##
========================================
+ Coverage 56.8% 57.0% +0.1%
========================================
Files 552 552
Lines 63064 63064
========================================
+ Hits 35856 35965 +109
+ Misses 24008 23905 -103
+ Partials 3200 3194 -6
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@@ -26,13 +26,32 @@ import ( | |||
"github.com/m3db/m3/src/x/log" | |||
) | |||
|
|||
var ( | |||
defaultMetricsSanitization = instrument.PrometheusMetricSanitization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do these defaults come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied from the dbnode test.
I reverted this change and added the metrics config in the test yaml again.
I can work on the default values later in separate PRs.
@@ -89,7 +89,7 @@ type AggregatorConfiguration struct { | |||
GaugePrefix *string `yaml:"gaugePrefix"` | |||
|
|||
// Stream configuration for computing quantiles. | |||
Stream streamConfiguration `yaml:"stream"` | |||
Stream *streamConfiguration `yaml:"stream"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why make this nillable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to cut the unused part in the test config yaml.
Just changed it back and added a minimal stream configuration in the test.
7c36a71
to
46a60f1
Compare
@@ -0,0 +1,278 @@ | |||
//go:build integration_v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get rid of one of these. Only need one tag here.
This commit adds resources.Aggregator interface with a few basic functions. It also adds an in-process implementation of the new interface which will start in process.
What this PR does / why we need it:
This PR adds resources.Aggregator interface with a few basic functions.
It also adds an in-process implementation of the new interface which will start in process.
More PRs to follow:
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: