[tests] Adds in-process implementation of resources.M3Resources #3792
Conversation
nbroyles
force-pushed
the
nb/setup
branch
3 times, most recently
from
068e750 to
4f67fa8
Compare
Codecov Report
@@ Coverage Diff @@
## master #3792 +/- ##
======================================
Coverage 57.0% 57.0%
======================================
Files 552 552
Lines 63077 63077
======================================
Hits 36004 36004
Misses 23878 23878
Partials 3195 3195
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| envConfig, err := discoverCfg.EnvironmentConfig(hostID) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return &admin.Host{ |
There was a problem hiding this comment.
IsolationGroup is empty? Will that affect the sharding algorithm?
There was a problem hiding this comment.
Ah yeah, I've got a change to support in an upcoming PR. For now, it's OK to be left blank.
This commit adds an implementation of resources.M3Resources that is backed by in-process components. Implementation is able of being configured using resources.SetupCluster which takes those components and turns them into a cluster ready to receive reads and writes.
What this PR does / why we need it:
This commit adds an implementation of resources.M3Resources that
is backed by in-process components. Implementation is able
of being configured using resources.SetupCluster which takes
those components and turns them into a cluster ready to
receive reads and writes.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: