Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Fix Graphite groupByNodes panic on missing agg function when using median #3582

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

yyin-sc
Copy link
Collaborator

@yyin-sc yyin-sc commented Jul 2, 2021

What this PR does / why we need it:

Fixes NPE bug when query groupByNodes using median aggregation function.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@yyin-sc yyin-sc requested a review from robskillington July 2, 2021 06:17
@yyin-sc yyin-sc changed the title [Query]Fix groupByNodes NPE when using median [Query]Fix groupByNodes panic when using median Jul 2, 2021
Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington changed the title [Query]Fix groupByNodes panic when using median [query] Fix Graphite groupByNodes panic on missing agg function when using median Jul 2, 2021
@robskillington robskillington enabled auto-merge (squash) July 2, 2021 17:49
@robskillington robskillington merged commit c35fa2d into m3db:master Jul 2, 2021
@yyin-sc yyin-sc deleted the evan-fix-group-by-nodes branch July 31, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants