Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Use optional ptr ints for per query limits to allow for specifying zero to disable limits #3376

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

robskillington
Copy link
Collaborator

@robskillington robskillington commented Mar 19, 2021

What this PR does / why we need it:

Previously setting zero would default to the 100k default max series limit which conflicts with how the header works (setting zero disables limit). This makes both behave consistently (config + headers now act the same, zero disables, omitting uses default and setting explicit number enables at that number).

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@robskillington robskillington enabled auto-merge (squash) March 19, 2021 20:19
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #3376 (8034ce7) into master (8034ce7) will not change coverage.
The diff coverage is n/a.

❗ Current head 8034ce7 differs from pull request most recent head 872006e. Consider uploading reports for the commit 872006e to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3376   +/-   ##
=======================================
  Coverage    72.4%    72.4%           
=======================================
  Files        1100     1100           
  Lines      102475   102475           
=======================================
  Hits        74225    74225           
  Misses      23146    23146           
  Partials     5104     5104           
Flag Coverage Δ
aggregator 76.9% <0.0%> (ø)
cluster 84.9% <0.0%> (ø)
collector 84.3% <0.0%> (ø)
dbnode 79.0% <0.0%> (ø)
m3em 74.4% <0.0%> (ø)
m3ninx 73.5% <0.0%> (ø)
metrics 19.8% <0.0%> (ø)
msg 74.5% <0.0%> (ø)
query 67.0% <0.0%> (ø)
x 80.3% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8034ce7...872006e. Read the comment docs.

@mway
Copy link
Collaborator

mway commented Mar 24, 2021

I'd really like to stop introducing pointer values in config, especially for scalar types. Maybe we could start using a consistent convention of "0 for disable, -1 for default", or a special magic value, or something like that? Open to ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants