[query] influxdb write improvements #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsharju
force-pushed
the
tsharju-influxdb-write-improvements
branch
2 times, most recently
from
074d0f8 to
5c534ad
Compare
Codecov Report
@@ Coverage Diff @@
## master #3373 +/- ##
==========================================
+ Coverage 56.8% 72.4% +15.5%
==========================================
Files 552 1101 +549
Lines 63077 102840 +39763
==========================================
+ Hits 35857 74498 +38641
+ Misses 24016 23229 -787
- Partials 3204 5113 +1909
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
This PR has been approved for quite a while already. Would there be something required from me to get it merged? |
tsharju
force-pushed
the
tsharju-influxdb-write-improvements
branch
2 times, most recently
from
50dfd4b to
155cc80
Compare
mhoffm-aiven
force-pushed
the
tsharju-influxdb-write-improvements
branch
from
155cc80 to
3bc2f6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For improved performance InfluxDB protocol suggest using
Content-Encoding: gzipfor the line protocol messages. At the moment, for example Telegraf sends InfluxDB output using gzip by default, influxdata/telegraf#8269. The current implementation of the M3 InfluxDB write handler did not support this. This PR adds this capability.Another fix included is specifying the timestamp precision for the timestamp included in the InfluxDB line protocol. InfluxDB client implementations send the precision along with the write requests and if this is not taken into account, the timestamp value is parsed with incorrect value due to the missing precision information.
Also, added fix for handling the case where the HTTP request body is empty.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: