[coordinator] Add config option to make rollup rules untimed #3343
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3343 +/- ##
=======================================
Coverage 72.4% 72.4%
=======================================
Files 1098 1098
Lines 101884 101889 +5
=======================================
+ Hits 73835 73853 +18
+ Misses 22957 22953 -4
+ Partials 5092 5083 -9
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| }, | ||
| timedSamples: []testGaugeMetricTimedSample{ | ||
| {value: 42}, | ||
| {value: 12, offset: 2 * time.Second}, |
There was a problem hiding this comment.
interesting, so these will actually get rolled up into one data point even though the resolution is one second?
There was a problem hiding this comment.
Yeah, so because timestamp gets stamped on the agg side, what you pass in is ignored.
I added another variety of test where we wait for the time before sending in the metric. That actually aggregates things into two datapoints.
shreyassrivatsan
force-pushed
the
ss/untimed
branch
from
7286ef8 to
8f50945
Compare
robskillington
changed the title
* master: [dbnode] Remove unused shardBlockVolume (#3347) Fix new Go 1.15+ vet check failures (#3345) [coordinator] Add config option to make rollup rules untimed (#3343) [aggregator] Raw TCP Client write queueing/buffering refactor (#3342) [dbnode] Fail M3TSZ encoding on DeltaOfDelta overflow (#3329)
What this PR does / why we need it:
This change adds a coordinator config option to force all rollup rules to be considered as untimed.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: