[coordinator] make drop timestamp apply to the metric rather than specific rule #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3310 +/- ##
=======================================
Coverage 72.4% 72.4%
=======================================
Files 1099 1099
Lines 101524 101524
=======================================
Hits 73595 73595
Misses 22841 22841
Partials 5088 5088
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
shreyassrivatsan
force-pushed
the
ss/drop
branch
from
dfa8930 to
13acf1e
Compare
wesleyk
approved these changes
Mar 2, 2021
shreyassrivatsan
force-pushed
the
ss/drop
branch
from
13acf1e to
f7dbb28
Compare
soundvibe
added a commit
that referenced
this pull request
Mar 3, 2021
* master: [aggregator] Move placement checks to a background job (#3315) [tests] Remove a few more usages of NoOpAllBootstrapper from tests (#3314) [coordinator] make drop timestamp apply to the metric rather than specific rule (#3310) Update server.go (#3298) Fix Data Race in checkoutSeriesWithLock (#3300) [query] Allow configuration of placement options (#3304)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for the drop timestamp tag to universally drop the timestamp while sending the metric to the aggregator.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: