Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Update peer bootstrap none available integration test #3282

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

vpranckaitis
Copy link
Collaborator

What this PR does / why we need it:

Updates peer bootstrap none available test to not rely on NoOpAllBootstrapper.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #3282 (6c488f4) into master (da44ea0) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3282     +/-   ##
=========================================
- Coverage    72.4%    72.4%   -0.1%     
=========================================
  Files        1099     1099             
  Lines      101504   101551     +47     
=========================================
+ Hits        73579    73608     +29     
- Misses      22849    22866     +17     
- Partials     5076     5077      +1     
Flag Coverage Δ
aggregator 76.4% <ø> (-0.1%) ⬇️
cluster 84.8% <ø> (-0.1%) ⬇️
collector 84.3% <ø> (ø)
dbnode 78.9% <ø> (+<0.1%) ⬆️
m3em 74.4% <ø> (ø)
m3ninx 73.5% <ø> (ø)
metrics 19.9% <ø> (ø)
msg 74.0% <ø> (-0.2%) ⬇️
query 67.3% <ø> (-0.1%) ⬇️
x 80.7% <ø> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da44ea0...101c49d. Read the comment docs.

log.Debug("servers are now up")

for i, s := range setups {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we run this with a timeout (e.g. waitUntil(isBootstrapped(), TIMEOUT))?

Feels like this could be flaky.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StartServer() implicitly waits for bootstrap. These asserts are not really needed, added them just to make it clearer what's being tested.

waitFn := ts.WaitUntilServerIsUp
if waitForBootstrap {
waitFn = ts.WaitUntilServerIsBootstrapped
}

@vpranckaitis vpranckaitis requested a review from notbdu February 26, 2021 10:30
Copy link
Contributor

@notbdu notbdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	src/dbnode/integration/peers_bootstrap_none_available_test.go
@vpranckaitis vpranckaitis merged commit 017f60d into master Mar 1, 2021
@vpranckaitis vpranckaitis deleted the vililus/fix_integration_test branch March 1, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants