Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry to write forwarding #2299

Merged
merged 5 commits into from
Apr 30, 2020
Merged

Add retry to write forwarding #2299

merged 5 commits into from
Apr 30, 2020

Conversation

rallen090
Copy link
Collaborator

What this PR does / why we need it:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@CLAassistant
Copy link

CLAassistant commented Apr 30, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@arnikola arnikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming CI passes

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the subscoping of the metrics scope for the retrier

@rallen090 rallen090 merged commit 5fc3afe into master Apr 30, 2020
@rallen090 rallen090 deleted the ra/forward-retry branch April 30, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants