[aggregator] Add compatibility for rollup rules with timed metrics #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schallert
reviewed
Apr 9, 2020
|
|
||
| // IncValuesOutOfOrder increments value or if not initialized is a no-op. | ||
| func (m CounterMetrics) IncValuesOutOfOrder() { | ||
| if m.valuesOutOfOrder != nil { |
There was a problem hiding this comment.
Do we expect to initialize a CounterMetrics without the constructor or is this just to be paranoid?
There was a problem hiding this comment.
Bit of both, I believe some integration tests do not initialize it and also this is for paranoia.
| // NB: we only need to record the value needed for derivative transformations. | ||
| // We currently only support first-order derivative transformations so we only | ||
| // need to keep one value. In the future if we need to support higher-order | ||
| // derivative transformations, we need to store an array of values here. | ||
| e.lastConsumedValues[aggTypeIdx] = value | ||
| if !math.IsNaN(curr.Value) { |
There was a problem hiding this comment.
Discussed offline why we bother passing evaluating the op if incoming sample is NaN but there may be transformations (such as count # samples) that still care.
src/aggregator/aggregator/entry.go
Outdated
| if sm.Tombstoned { | ||
| e.RUnlock() | ||
| timeLock.RUnlock() | ||
| // e.metrics.timed.tombstonedMetadata.Inc(1) |
There was a problem hiding this comment.
Ah good call.
src/aggregator/aggregator/entry.go
Outdated
| if len(sm.Pipelines) == 0 { | ||
| e.RUnlock() | ||
| timeLock.RUnlock() | ||
| e.metrics.untimed.noPipelinesInMetadata.Inc(1) |
There was a problem hiding this comment.
Yup, ty good call.
src/metrics/transformation/binary.go
Outdated
| diff := curr.Value - prev.Value | ||
| if diff < 0 { | ||
| // // Treated as a counter reset, take the curr value as counted elements. | ||
| // return Datapoint{TimeNanos: curr.TimeNanos, Value: curr.Value} |
schallert
approved these changes
Apr 9, 2020
fishie9
pushed a commit
that referenced
this pull request
Apr 14, 2020
fix integration test fix integration test fix Add metrics for passthrough in follower instances [aggregator] Add compatibility for rollup rules with timed metrics (#2251) Add pass-through in m3aggregator using rawtcp server fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds compatibility for rollup rules to the aggregator with timed metric types.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: