Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coordinator] Ensure does not grow M3Msg buffer if message over max size #2207

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

On the occasion that a message is sent over max size, it can cause large allocations. This avoids increasing the buffer before checking if over max size to avoid these large allocations when this occurs.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

Copy link
Collaborator

@arnikola arnikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #2207 into master will decrease coverage by 0.3%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2207     +/-   ##
========================================
- Coverage    72.1%   71.7%   -0.4%     
========================================
  Files        1022    1022             
  Lines       88793   88793             
========================================
- Hits        64041   63727    -314     
- Misses      20441   20746    +305     
- Partials     4311    4320      +9     
Flag Coverage Δ
#aggregator 82.0% <ø> (-0.1%) ⬇️
#cluster 85.2% <ø> (-0.2%) ⬇️
#collector 82.8% <ø> (+11.4%) ⬆️
#dbnode 78.0% <ø> (-0.9%) ⬇️
#m3em 74.4% <ø> (ø)
#m3ninx 72.3% <ø> (ø)
#m3nsch 51.1% <ø> (ø)
#metrics 17.6% <ø> (ø)
#msg 74.0% <100.0%> (-0.8%) ⬇️
#query 68.4% <ø> (ø)
#x 83.2% <ø> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e7df8...4e34743. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #2207 into master will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2207     +/-   ##
========================================
+ Coverage    72.1%   72.2%   +0.1%     
========================================
  Files        1022    1022             
  Lines       88793   88793             
========================================
+ Hits        64041   64132     +91     
+ Misses      20441   20358     -83     
+ Partials     4311    4303      -8     
Flag Coverage Δ
#aggregator 82.0% <ø> (-0.1%) ⬇️
#cluster 85.2% <ø> (-0.2%) ⬇️
#collector 82.8% <ø> (+11.4%) ⬆️
#dbnode 79.0% <ø> (+0.2%) ⬆️
#m3em 74.4% <ø> (ø)
#m3ninx 72.3% <ø> (ø)
#m3nsch 51.1% <ø> (ø)
#metrics 17.6% <ø> (ø)
#msg 74.8% <100.0%> (ø)
#query 68.4% <ø> (ø)
#x 83.2% <ø> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e7df8...4e34743. Read the comment docs.

@robskillington robskillington merged commit c539609 into master Mar 12, 2020
@robskillington robskillington deleted the r/fix-m3msg-decode-large-message-allocation branch March 12, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants