Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[goreleaser] Only build amd64 architecture for m3query releases #2202

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

Without specifying architecture goreleaser by default builds both amd64 and i386. To speed up releases this makes m3query only build amd64 like all our other binaries.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #2202 into master will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2202     +/-   ##
========================================
- Coverage    72.2%   72.2%   -0.1%     
========================================
  Files        1022    1022             
  Lines       88793   88793             
========================================
- Hits        64145   64125     -20     
- Misses      20352   20365     +13     
- Partials     4296    4303      +7     
Flag Coverage Δ
#aggregator 82.1% <ø> (-0.1%) ⬇️
#cluster 85.2% <ø> (-0.2%) ⬇️
#collector 82.8% <ø> (ø)
#dbnode 79.0% <ø> (-0.1%) ⬇️
#m3em 74.4% <ø> (ø)
#m3ninx 72.3% <ø> (-0.1%) ⬇️
#m3nsch 51.1% <ø> (ø)
#metrics 17.6% <ø> (ø)
#msg 74.9% <ø> (ø)
#query 68.4% <ø> (ø)
#x 83.2% <ø> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527d5f5...23ad916. Read the comment docs.

Copy link
Collaborator

@arnikola arnikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robskillington robskillington merged commit fa5c657 into master Mar 10, 2020
@robskillington robskillington deleted the r/m3query-release-just-amd64 branch March 10, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants