Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Add client bad request/internal error distinction for metrics and sampled logs #2201

Merged
merged 5 commits into from
Mar 10, 2020

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

This allows for universal metrics to be emitted for bad request / internal error breakdowns, unrelated to the pathway that reaches the client (i.e. for coordinator via remote write or from aggregator).

It also adds the ability to sample logs directly from the client by config, just set logErrorSampleRate greater than 0 in the client config.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

Copy link
Collaborator

@martin-mao martin-mao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #2201 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2201   +/-   ##
======================================
  Coverage    72.4%   72.4%           
======================================
  Files        1022    1022           
  Lines       89900   89900           
======================================
  Hits        65133   65133           
  Misses      20462   20462           
  Partials     4305    4305           
Flag Coverage Δ
#aggregator 82.1% <0.0%> (ø)
#cluster 85.3% <0.0%> (ø)
#collector 82.8% <0.0%> (ø)
#dbnode 79.4% <0.0%> (ø)
#m3em 74.4% <0.0%> (ø)
#m3ninx 72.3% <0.0%> (ø)
#m3nsch 51.1% <0.0%> (ø)
#metrics 17.6% <0.0%> (ø)
#msg 74.8% <0.0%> (ø)
#query 68.4% <0.0%> (ø)
#x 83.1% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 496ce8c...593f0fb. Read the comment docs.

@robskillington robskillington merged commit e6ef467 into master Mar 10, 2020
@robskillington robskillington deleted the r/client-sampled-logs-better-metrics branch March 10, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants