[query] api: Allow in-place topic consumer updates #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now there are no HTTP APIs for updating a topic's consumers in-place. The only way to do so would be deleting + recreating the topic. This adds support for `PUT`-ing a topic to update its consumers in-place. Updating number of shards is currently not supported.
Codecov Report
@@ Coverage Diff @@
## master #2186 +/- ##
======================================
Coverage 72.2% 72.2%
======================================
Files 1017 1017
Lines 88268 88268
======================================
Hits 63770 63770
Misses 20214 20214
Partials 4284 4284
Continue to review full report at Codecov.
|
arnikola
approved these changes
Mar 2, 2020
| @@ -0,0 +1,136 @@ | |||
| // Copyright (c) 2019 Uber Technologies, Inc. | |||
| ) | ||
|
|
||
| const ( | ||
| // UpdateURL is the url for the topic delete handler (with the PUT method). |
There was a problem hiding this comment.
nit: topic update handler
| UpdateHTTPMethod = http.MethodPut | ||
| ) | ||
|
|
||
| // UpdateHandler is the handler for topic adds. |
There was a problem hiding this comment.
nit: topic updates. Also, probably don't need to export UpdateHandler?
| client clusterclient.Client, | ||
| cfg config.Configuration, | ||
| instrumentOpts instrument.Options, | ||
| ) *UpdateHandler { |
There was a problem hiding this comment.
nit: probably should return an Http.Handler rather than explicitly a *UpdateHandler?
| @@ -0,0 +1,155 @@ | |||
| // Copyright (c) 2018 Uber Technologies, Inc. | |||
Comment on lines
+125
to
+128
| if err != nil { | ||
| logger.Error("unable to convert topic to protobuf", zap.Error(err)) | ||
| xhttp.Error(w, err, http.StatusInternalServerError) | ||
| return |
There was a problem hiding this comment.
Is this fine to error here if the update has already happened?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Right now there are no HTTP APIs for updating a topic's consumers
in-place. The only way to do so would be deleting + recreating the
topic.
This adds support for
PUT-ing a topic to update its consumersin-place. Updating number of shards is currently not supported.
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: