Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coordinator] Add support for Graphite Grafana plugin /find POST requests #2153

Merged
merged 5 commits into from
Mar 16, 2020

Conversation

tejasbhosale009
Copy link
Contributor

Added code that will support to grafana to show graphs using m3db ..

@claassistantio
Copy link

claassistantio commented Feb 17, 2020

CLA assistant check
All committers have signed the CLA.

@fingon
Copy link
Contributor

fingon commented Feb 19, 2020

Grafana works fine without this too (using Prometheus), I guess this is needed for Graphite? What is the difference anyway, POSTed form field "query" as opposed to "query" parameter in the url?

@robskillington
Copy link
Collaborator

robskillington commented Feb 20, 2020

@tejasbhosale009 thanks for the contribution, this makes sense for Graphite find (I believe it's POST request?). I think we need a unit test before we can merge this for regression testing purposes, would you mind adding a test that sends a POST request?

Relevant datasource POST request for graphite find:
https://github.com/grafana/grafana/blob/master/public/app/plugins/datasource/graphite/datasource.ts#L324-L334

    const httpOptions: any = {
      method: 'POST',
      url: '/metrics/find',
      params: {},
      data: `query=${interpolatedQuery}`,
      headers: {
        'Content-Type': 'application/x-www-form-urlencoded',
      },
      // for cancellations
      requestId: options.requestId,
    };

@robskillington robskillington changed the title added support for grafana [coordinator] Add support for Graphite Grafana plugin /find POST requests Feb 20, 2020
@robskillington
Copy link
Collaborator

I added the test and merged master in.

@robskillington robskillington merged commit fb46ae7 into m3db:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants