[dbnode] Add placement set handler for perform set operations #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2108 +/- ##
======================================
Coverage 32.7% 32.7%
======================================
Files 4 4
Lines 336 336
======================================
Hits 110 110
Misses 216 216
Partials 10 10
Continue to review full report at Codecov.
|
|
TODO tests |
schallert
approved these changes
Jan 15, 2020
| "time" | ||
|
|
||
| "github.com/m3db/m3/src/cluster/placement" | ||
|
|
| curPlacement, err := service.Placement() | ||
| if err != nil { | ||
| logger.Error("unable to get current placement", zap.Error(err)) | ||
| xhttp.Error(w, err, http.StatusInternalServerError) |
There was a problem hiding this comment.
Let's make this StatusNotFound? Thinking from the operator perspective, there are times where we have to type check a 404 from Coordinator API.
There was a problem hiding this comment.
Sounds good, I added this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows us to do goal state based placement updates, must be used with care!!
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: