-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[etcd] Upgrade etcd client library to 3.4.3 to fix data race in tests #2101
[etcd] Upgrade etcd client library to 3.4.3 to fix data race in tests #2101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending green build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending CI. @vdarulis @andrewmains12 this might require bumping some deps internally @ Uber as well.
Codecov Report
@@ Coverage Diff @@
## master #2101 +/- ##
=========================================
+ Coverage 53% 72.3% +19.2%
=========================================
Files 988 1008 +20
Lines 97296 86653 -10643
=========================================
+ Hits 51649 62713 +11064
+ Misses 41073 19741 -21332
+ Partials 4574 4199 -375
Continue to review full report at Codecov.
|
Thanks @schallert - been eyeing to do this as well. Just curious, how does this even work without bumping grpc dependency? |
What this PR does / why we need it:
Fixes the data races we were seeing in unit tests. The earliest release that includes the fix is on the 3.4 release so we are upgrading to 3.4.3.
Our "TestClient" unit test was experiencing data race in package
src/cluster/client/etcd
.Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: