[query] Custom handler support #2073
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2073 +/- ##
========================================
- Coverage 72.5% 72.4% -0.2%
========================================
Files 1005 1007 +2
Lines 86287 86395 +108
========================================
- Hits 62584 62552 -32
- Misses 19530 19669 +139
- Partials 4173 4174 +1
Continue to review full report at Codecov.
|
| @@ -42,6 +42,11 @@ const ( | |||
| // of propagating aggregator placement to clients, usually needed when there is | |||
| // a large amount of clients sending traffic to m3aggregator. | |||
| defaultM3AggWarmupDuration = 0 | |||
|
|
|||
| // DefaultServiceEnvironment is the default service ID environment. | |||
| DefaultServiceEnvironment = "default_env" | |||
There was a problem hiding this comment.
Are these already declared somewhere else or were they moved?
There was a problem hiding this comment.
Yeah, it was moved from headers.go; moved it back 👍
| } | ||
|
|
||
| handler := httpd.NewHandler(handlerOptions, runOpts.CustomHandlers...) |
src/query/executor/options.go
Outdated
| "github.com/m3db/m3/src/query/storage" | ||
|
|
There was a problem hiding this comment.
nit: Unnecessary end line between imports?
| // MetricsTypeHeader sets the write or read metrics type to restrict | ||
| // metrics to. | ||
| // Valid values are "unaggregated" or "aggregated". | ||
| MetricsTypeHeader = "M3-Metrics-Type" |
There was a problem hiding this comment.
Do these need to be moved back to headers.go or staying here?
arnikola
force-pushed
the
arnikola/custom-handler
branch
from
0310f08 to
842a9e1
Compare
| Name: nameBytes, | ||
| Value: matchValues, | ||
| Type: models.MatchField, | ||
| Name: nameBytes, |
There was a problem hiding this comment.
Perhaps remove var matchValues = []byte(".*") ? Looks like it's not used anymore.
src/query/server/query.go
Outdated
| CustomHandlers []options.CustomHandler | ||
|
|
||
| // CustomParseFunction is a custom parsing function. | ||
| CustomParseFunction promql.ParseFn |
There was a problem hiding this comment.
nit: Should we call this CustomPromQLParseFunction? In case we need to add another language, etc which may cause a backwards incompat change for those using this code?
What this PR does / why we need it:
Allows custom 3rd party handlers.
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: