-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Restrict query by header tag #2053
Changes from 2 commits
f6fe230
405d842
f6640a1
fd66d0a
991a838
bfaca7d
1ca734e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,6 +56,12 @@ const ( | |
// metrics type. | ||
MetricsStoragePolicyHeader = "M3-Storage-Policy" | ||
|
||
// FetchRestrictLabels restricts all fetches to match certain labels. | ||
FetchRestrictLabels = "M3-Fetch-Restrict-Labels" | ||
|
||
// FetchStripLabels strips certain labels from the result. | ||
FetchStripLabels = "M3-Fetch-Strip-Labels" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Think we were moving towards using just one header, called Perhaps: QueryOptionsJSONHeader = "M3-Query-Options-JSON" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh yeah oops forgot to prune this one There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moving to |
||
|
||
// UnaggregatedStoragePolicy specifies the unaggregated storage policy. | ||
UnaggregatedStoragePolicy = "unaggregated" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this still needs to happen yeah? Otherwise we'll get wrong tag options being used for these matchers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I guess; it's only really relevant (atm) if you're overriding the name tag, but will do it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a follow up, this was refactored to no longer be neccessary