[build] goreleaser: ensure cgo disabled in build #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We set `CGO_ENABLED=0` in our make targets, but hadn't been doing so in our `goreleaser` config. Disabling cgo ensures our builds will work across OS's that may use different libc implementations.
Codecov Report
@@ Coverage Diff @@
## master #2005 +/- ##
=======================================
Coverage 63.6% 63.6%
=======================================
Files 1124 1124
Lines 106752 106752
=======================================
Hits 67919 67919
Misses 34485 34485
Partials 4348 4348
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set
CGO_ENABLED=0in our make targets, but hadn't been doing so inour
goreleaserconfig. Disabling cgo ensures our builds will workacross OS's that may use different libc implementations.
What this PR does / why we need it:
Fixes #2003
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: