[query] Add endpoint that parses query to an AST #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2002 +/- ##
=========================================
+ Coverage 63% 63.5% +0.4%
=========================================
Files 1123 1119 -4
Lines 106854 106426 -428
=========================================
+ Hits 67419 67635 +216
+ Misses 35061 34455 -606
+ Partials 4374 4336 -38
Continue to review full report at Codecov.
|
robskillington
changed the title
| return nodeMap, nil | ||
| } | ||
|
|
||
| func parsingThreshold(r *http.Request) bool { |
| @@ -53,6 +53,7 @@ const ( | |||
| timeParam = "time" | |||
| queryParam = "query" | |||
| debugParam = "debug" | |||
| thresholdParam = "threshold" | |||
There was a problem hiding this comment.
Seems like this is dead code too?
robskillington
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds an endpoint that parses and returns a JSON representation of the given query.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: