Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] add specialized matchers for empty EQ/NEQ matchers #1986

Merged
merged 4 commits into from
Oct 23, 2019

Conversation

arnikola
Copy link
Collaborator

@arnikola arnikola commented Oct 6, 2019

What this PR does / why we need it:
Fixes #1873

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #1986 into master will increase coverage by 0.5%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1986     +/-   ##
=========================================
+ Coverage      63%    63.6%   +0.5%     
=========================================
  Files        1123     1122      -1     
  Lines      106854   106597    -257     
=========================================
+ Hits        67419    67812    +393     
+ Misses      35061    34450    -611     
+ Partials     4374     4335     -39
Flag Coverage Δ
#aggregator 79.7% <ø> (ø) ⬆️
#cluster 52.3% <ø> (-4%) ⬇️
#collector 57.9% <ø> (-5.9%) ⬇️
#dbnode 64.6% <ø> (+0.6%) ⬆️
#m3em 59.6% <ø> (ø) ⬆️
#m3ninx 27.4% <ø> (-33.5%) ⬇️
#m3nsch 41.4% <ø> (-9.8%) ⬇️
#metrics 53% <ø> (+35.2%) ⬆️
#msg 74% <ø> (-0.8%) ⬇️
#query 63.4% <100%> (-4.8%) ⬇️
#x 39.5% <ø> (-35.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b267303...71f6068. Read the comment docs.

@arnikola arnikola force-pushed the arnikola/empty-matchers branch from a0ac744 to 0afdba9 Compare October 7, 2019 01:36
@arnikola arnikola force-pushed the arnikola/fix-tag-funcs branch from c73dd15 to 6c00f8a Compare October 15, 2019 13:48
@arnikola arnikola force-pushed the arnikola/empty-matchers branch from 0afdba9 to 71f6068 Compare October 15, 2019 22:31
@arnikola arnikola closed this Oct 16, 2019
@arnikola
Copy link
Collaborator Author

github please

@arnikola arnikola reopened this Oct 16, 2019
@arnikola arnikola changed the base branch from arnikola/fix-tag-funcs to master October 16, 2019 13:45
@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #1986 into master will decrease coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1986     +/-   ##
=========================================
- Coverage    63.6%    63.6%   -0.1%     
=========================================
  Files        1124     1122      -2     
  Lines      106753   106597    -156     
=========================================
- Hits        67917    67812    -105     
+ Misses      34488    34450     -38     
+ Partials     4348     4335     -13
Flag Coverage Δ
#aggregator 79.7% <ø> (ø) ⬆️
#cluster 52.3% <ø> (-4.1%) ⬇️
#collector 57.9% <ø> (-5.9%) ⬇️
#dbnode 64.6% <ø> (-0.4%) ⬇️
#m3em 59.6% <ø> (ø) ⬆️
#m3ninx 27.4% <ø> (-33.7%) ⬇️
#m3nsch 41.4% <ø> (-9.8%) ⬇️
#metrics 53% <ø> (+35.2%) ⬆️
#msg 74% <ø> (-0.8%) ⬇️
#query 63.4% <100%> (-5.3%) ⬇️
#x 39.5% <ø> (-35.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eb7e3f...383c4be. Read the comment docs.

@arnikola arnikola merged commit e3d0f4f into master Oct 23, 2019
@arnikola arnikola deleted the arnikola/empty-matchers branch October 23, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PromQL: matchers on labels with an empty value are not correctly handled
2 participants