[query] Fix early closing in lazy blocks #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnikola
changed the base branch from
master
to
arnikola/fanout-integration-tests
| @@ -307,3 +306,24 @@ ATTEMPTS=3 TIMEOUT=1 retry_with_backoff render_carbon 9 14 max_fetch_series_limi | |||
| ATTEMPTS=3 TIMEOUT=1 retry_with_backoff find_carbon 16 remote_store_cluster-c_complete_tags_warning | |||
| ATTEMPTS=3 TIMEOUT=1 retry_with_backoff find_carbon 9 max_fetch_series_limit_applied,remote_store_cluster-c_complete_tags_warning | |||
|
|
|||
| # NB (arnikola): following tests are unrelated to fanout but there's no good | |||
| # testbed story yet; reported query execution errors will be added here and | |||
| # migrated to a proper testbed when it becomes available. | |||
There was a problem hiding this comment.
Hm can we add common methods like write_metrics to just common.sh and add these to the prometheus/test.sh perhaps (which can call the shared method)?
Seems a better place than the fanout test perhaps?
| # testbed story yet; reported query execution errors will be added here and | ||
| # migrated to a proper testbed when it becomes available. | ||
|
|
||
| function func { |
There was a problem hiding this comment.
nit: Maybe we call this query_instant to reflect it's doing an instant query vs range (little more clear than just func perhaps).
robskillington
approved these changes
Oct 6, 2019
arnikola
changed the base branch from
arnikola/fanout-integration-tests
to
master
robskillington
force-pushed
the
master
branch
from
fdbef61 to
0c6a0fe
Compare
arnikola
force-pushed
the
arnikola/fix-tag-funcs
branch
from
c73dd15 to
6c00f8a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1985 +/- ##
=========================================
- Coverage 63.6% 63.6% -0.1%
=========================================
Files 1122 1122
Lines 106544 106545 +1
=========================================
- Hits 67808 67783 -25
- Misses 34405 34428 +23
- Partials 4331 4334 +3
Continue to review full report at Codecov.
|
arnikola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes a user issue reported in tag replace function
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: