Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aggregator] Add aggregator to release binaries #1943

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

This adds the m3aggregator to the release binaries.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

Copy link
Collaborator

@arnikola arnikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnikola arnikola added the ci Triggers CI (useful for external contributors) label Sep 16, 2019
@schallert schallert removed the ci Triggers CI (useful for external contributors) label Sep 16, 2019
@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #1943 into master will decrease coverage by <.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1943     +/-   ##
=========================================
- Coverage    63.4%    63.4%   -0.1%     
=========================================
  Files        1119     1119             
  Lines      105422   105422             
=========================================
- Hits        66940    66900     -40     
- Misses      34213    34238     +25     
- Partials     4269     4284     +15
Flag Coverage Δ
#aggregator 79.7% <ø> (-0.1%) ⬇️
#cluster 56.3% <ø> (ø) ⬆️
#collector 63.7% <ø> (ø) ⬆️
#dbnode 64.8% <ø> (-0.1%) ⬇️
#m3em 59.6% <ø> (ø) ⬆️
#m3ninx 61.1% <ø> (-0.1%) ⬇️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.7% <ø> (ø) ⬆️
#msg 74.7% <ø> (-0.2%) ⬇️
#query 68.2% <ø> (-0.1%) ⬇️
#x 75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d767c88...8ffd246. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #1943 into master will decrease coverage by <.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1943     +/-   ##
=========================================
- Coverage    63.4%    63.4%   -0.1%     
=========================================
  Files        1119     1119             
  Lines      105422   105422             
=========================================
- Hits        66940    66900     -40     
- Misses      34213    34238     +25     
- Partials     4269     4284     +15
Flag Coverage Δ
#aggregator 79.7% <ø> (-0.1%) ⬇️
#cluster 56.3% <ø> (ø) ⬆️
#collector 63.7% <ø> (ø) ⬆️
#dbnode 64.8% <ø> (-0.1%) ⬇️
#m3em 59.6% <ø> (ø) ⬆️
#m3ninx 61.1% <ø> (-0.1%) ⬇️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.7% <ø> (ø) ⬆️
#msg 74.7% <ø> (-0.2%) ⬇️
#query 68.2% <ø> (-0.1%) ⬇️
#x 75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d767c88...8ffd246. Read the comment docs.

@robskillington robskillington merged commit 58e875f into m3db:master Sep 16, 2019
@robskillington robskillington deleted the r/add-aggregator branch September 16, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants