Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Tally to 3.3.10 #1660

Merged
merged 2 commits into from
May 23, 2019
Merged

Upgrade Tally to 3.3.10 #1660

merged 2 commits into from
May 23, 2019

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

Upgrade Tally to 3.3.10 to fix Tally Prometheus reporter listen port conflict not panic'ing correctly with the correct error message

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #1660 into master will decrease coverage by <.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1660     +/-   ##
========================================
- Coverage    71.9%   71.9%   -0.1%     
========================================
  Files         964     964             
  Lines       80742   80672     -70     
========================================
- Hits        58116   58029     -87     
- Misses      18827   18843     +16     
- Partials     3799    3800      +1
Flag Coverage Δ
#aggregator 82.3% <ø> (-0.1%) ⬇️
#cluster 85.7% <ø> (ø) ⬆️
#collector 63.9% <ø> (ø) ⬆️
#dbnode 80% <ø> (-0.1%) ⬇️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.7% <ø> (ø) ⬆️
#query 66.3% <ø> (ø) ⬆️
#x 86.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab47ae9...15c4e85. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #1660 into master will decrease coverage by <.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1660     +/-   ##
========================================
- Coverage    71.9%   71.9%   -0.1%     
========================================
  Files         964     964             
  Lines       80742   80672     -70     
========================================
- Hits        58116   58029     -87     
- Misses      18827   18843     +16     
- Partials     3799    3800      +1
Flag Coverage Δ
#aggregator 82.3% <ø> (-0.1%) ⬇️
#cluster 85.7% <ø> (ø) ⬆️
#collector 63.9% <ø> (ø) ⬆️
#dbnode 80% <ø> (-0.1%) ⬇️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.7% <ø> (ø) ⬆️
#query 66.3% <ø> (ø) ⬆️
#x 86.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab47ae9...15c4e85. Read the comment docs.

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #1660 into master will decrease coverage by <.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1660     +/-   ##
========================================
- Coverage    71.9%   71.9%   -0.1%     
========================================
  Files         964     964             
  Lines       80742   80672     -70     
========================================
- Hits        58116   58029     -87     
- Misses      18827   18843     +16     
- Partials     3799    3800      +1
Flag Coverage Δ
#aggregator 82.3% <ø> (-0.1%) ⬇️
#cluster 85.7% <ø> (ø) ⬆️
#collector 63.9% <ø> (ø) ⬆️
#dbnode 80% <ø> (-0.1%) ⬇️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.7% <ø> (ø) ⬆️
#query 66.3% <ø> (ø) ⬆️
#x 86.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab47ae9...15c4e85. Read the comment docs.

@robskillington robskillington merged commit 6b9e962 into master May 23, 2019
@robskillington robskillington deleted the r/upgrade-tally-3.3.10 branch May 23, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants