Fix ReturnUnfulfilledForCorruptCommitLogFiles not propagating to bootstrapper options #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1639 +/- ##
========================================
- Coverage 72.1% 65.8% -6.4%
========================================
Files 959 840 -119
Lines 79817 72541 -7276
========================================
- Hits 57594 47762 -9832
- Misses 18469 21407 +2938
+ Partials 3754 3372 -382
Continue to review full report at Codecov.
|
added 2 commits
May 16, 2019 16:21
….com:m3db/m3 into r/plumb-return-unfulfilled-commitlog-options
richardartoul
approved these changes
May 16, 2019
| // BootstrapFilesystemConfiguration specifies config for the fs bootstrapper. | ||
| type BootstrapFilesystemConfiguration struct { | ||
| // NumProcessorsPerCPU is the number of processors per CPU. | ||
| NumProcessorsPerCPU float64 `yaml:"numProcessorsPerCPU" validate:"min=0.0"` | ||
| } | ||
|
|
||
| func (c BootstrapFilesystemConfiguration) numCPUs() int { | ||
| return int(math.Ceil(float64(c.NumProcessorsPerCPU * float64(runtime.NumCPU())))) |
There was a problem hiding this comment.
Can you break this up into a few vars, took me a minute to unpack it
|
|
||
| // BootstrapConfigurationValidator can be used to validate the option sets | ||
| // that the bootstrap configuration builds. | ||
| // Useful for tests and perhaps verifying same options set across multiple |
There was a problem hiding this comment.
"the same options are set"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes ReturnUnfulfilledForCorruptCommitLogFiles config field not properly being propagated to the commit log bootstrapper options.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: