Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Remove query conversion lru cache #1546

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Conversation

benraskin92
Copy link
Collaborator

Resolves the panic in #1542

@benraskin92 benraskin92 requested a review from prateek April 11, 2019 01:48
@benraskin92 benraskin92 marked this pull request as ready for review April 11, 2019 01:50
Copy link
Collaborator

@prateek prateek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might have to rebase

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #1546 into master will increase coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1546     +/-   ##
========================================
+ Coverage    71.7%   71.7%   +<.1%     
========================================
  Files         948     947      -1     
  Lines       78066   77981     -85     
========================================
- Hits        55986   55947     -39     
+ Misses      18430   18391     -39     
+ Partials     3650    3643      -7
Flag Coverage Δ
#aggregator 82.3% <ø> (ø) ⬆️
#cluster 85.7% <ø> (ø) ⬆️
#collector 63.7% <ø> (ø) ⬆️
#dbnode 79.9% <ø> (ø) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 73.9% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.5% <ø> (ø) ⬆️
#msg 75% <ø> (+0.1%) ⬆️
#query 66.5% <100%> (-0.1%) ⬇️
#x 85.7% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2422428...d839981. Read the comment docs.

@benraskin92 benraskin92 merged commit 0a395df into master Apr 11, 2019
@benraskin92 benraskin92 deleted the braskin/1542_query_panic branch April 11, 2019 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants