Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write read latency histogram metrics to DB client and emit from coordinator #1533

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

robskillington
Copy link
Collaborator

No description provided.

@robskillington robskillington force-pushed the r/add-write-read-latency-histogram-metrics branch from 4f0f119 to eef4aa5 Compare April 4, 2019 20:25
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #1533 into master will decrease coverage by 10.7%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1533      +/-   ##
=========================================
- Coverage    59.8%   49.1%   -10.8%     
=========================================
  Files         846      81     -765     
  Lines       72189    7270   -64919     
=========================================
- Hits        43233    3575   -39658     
+ Misses      25765    3458   -22307     
+ Partials     3191     237    -2954
Flag Coverage Δ
#aggregator 49.6% <ø> (-19.7%) ⬇️
#cluster ?
#collector 39.1% <ø> (-8.8%) ⬇️
#dbnode ?
#m3em ?
#m3ninx ?
#m3nsch ?
#metrics ?
#msg ?
#query ?
#x ?

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16c41d...eef4aa5. Read the comment docs.

Copy link
Collaborator

@benraskin92 benraskin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington merged commit 5a72ada into master Apr 4, 2019
@robskillington robskillington deleted the r/add-write-read-latency-histogram-metrics branch April 4, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants