Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api] placement: return early on placement err #1391

Merged
merged 1 commit into from
Feb 20, 2019
Merged

[api] placement: return early on placement err #1391

merged 1 commit into from
Feb 20, 2019

Conversation

schallert
Copy link
Collaborator

If we don't exit early then we'll panic when trying to .Proto() the
nil placement.

robskillington
robskillington approved these changes Feb 20, 2019
View reviewed changes
Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schallert
[api] placement: return early on placement err
f566107 
If we don't exit early then we'll panic when trying to `.Proto()` the
nil placement.
@schallert schallert force-pushed the schallert/fix_placement_get_panic branch from ae2b301 to f566107 Compare February 20, 2019 04:02
@schallert schallert merged commit bd3cc15 into master Feb 20, 2019
@schallert schallert deleted the schallert/fix_placement_get_panic branch February 20, 2019 04:13
@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #1391 into master will decrease coverage by <.1%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1391     +/-   ##
========================================
- Coverage    70.7%   70.7%   -0.1%     
========================================
  Files         827     827             
  Lines       71228   71229      +1     
========================================
  Hits        50373   50373             
+ Misses      17549   17548      -1     
- Partials     3306    3308      +2
Flag Coverage Δ
#aggregator 82.3% <ø> (ø) ⬆️
#cluster 85.9% <ø> (ø) ⬆️
#collector 63.7% <ø> (ø) ⬆️
#dbnode 80.6% <ø> (ø) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.2% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 65.2% <0%> (-0.1%) ⬇️
#x 76% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8b1fc...f566107. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #1391 into master will decrease coverage by <.1%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1391     +/-   ##
========================================
- Coverage    70.7%   70.7%   -0.1%     
========================================
  Files         827     827             
  Lines       71228   71229      +1     
========================================
  Hits        50373   50373             
+ Misses      17549   17548      -1     
- Partials     3306    3308      +2
Flag Coverage Δ
#aggregator 82.3% <ø> (ø) ⬆️
#cluster 85.9% <ø> (ø) ⬆️
#collector 63.7% <ø> (ø) ⬆️
#dbnode 80.6% <ø> (ø) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.2% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 65.2% <0%> (-0.1%) ⬇️
#x 76% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8b1fc...f566107. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #1391 into master will decrease coverage by <.1%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1391     +/-   ##
========================================
- Coverage    70.7%   70.7%   -0.1%     
========================================
  Files         827     827             
  Lines       71228   71229      +1     
========================================
  Hits        50373   50373             
+ Misses      17549   17548      -1     
- Partials     3306    3308      +2
Flag Coverage Δ
#aggregator 82.3% <ø> (ø) ⬆️
#cluster 85.9% <ø> (ø) ⬆️
#collector 63.7% <ø> (ø) ⬆️
#dbnode 80.6% <ø> (ø) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.2% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 65.2% <0%> (-0.1%) ⬇️
#x 76% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8b1fc...f566107. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robskillington robskillington robskillington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schallert @robskillington