Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve carbon ingestion performance #1327

Merged
merged 20 commits into from
Jan 30, 2019
Merged

Improve carbon ingestion performance #1327

merged 20 commits into from
Jan 30, 2019

Conversation

richardartoul
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #1327 into master will decrease coverage by 8.2%.
The diff coverage is 64.2%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1327     +/-   ##
========================================
- Coverage    70.7%   62.4%   -8.3%     
========================================
  Files         814     806      -8     
  Lines       69314   68813    -501     
========================================
- Hits        49005   42961   -6044     
- Misses      17181   22818   +5637     
+ Partials     3128    3034     -94
Flag Coverage Δ
#aggregator 74.3% <ø> (-7.2%) ⬇️
#cluster 70.3% <ø> (-15.3%) ⬇️
#collector 78.4% <ø> (ø) ⬆️
#dbnode 75.4% <ø> (-5.6%) ⬇️
#m3em 68.3% <ø> (-4.9%) ⬇️
#m3ninx 72.9% <ø> (-1.7%) ⬇️
#m3nsch 28.4% <ø> (-22.8%) ⬇️
#metrics 17.8% <0%> (-0.1%) ⬇️
#msg 75% <ø> (ø) ⬆️
#query 45.7% <69.2%> (-18.6%) ⬇️
#x 72.7% <ø> (-3.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c85f85...99e7b41. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 29, 2019 •
edited
Loading

Codecov Report

Merging #1327 into master will increase coverage by <.1%.
The diff coverage is 64.2%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1327     +/-   ##
========================================
+ Coverage    70.5%   70.6%   +<.1%     
========================================
  Files         816     814      -2     
  Lines       69452   69316    -136     
========================================
- Hits        49033   48999     -34     
+ Misses      17291   17180    -111     
- Partials     3128    3137      +9
Flag Coverage Δ
#aggregator 81.4% <ø> (-0.1%) ⬇️
#cluster 85.6% <ø> (ø) ⬆️
#collector 78.4% <ø> (ø) ⬆️
#dbnode 80.9% <ø> (-0.1%) ⬇️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.6% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.8% <0%> (-0.1%) ⬇️
#msg 74.9% <ø> (-0.2%) ⬇️
#query 64.4% <69.2%> (+0.4%) ⬆️
#x 75.9% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c85f85...8b9a7db. Read the comment docs.

robskillington
robskillington reviewed Jan 30, 2019
View reviewed changes
src/cmd/services/m3coordinator/ingest/carbon/ingest.go Outdated
m3xserver "github.com/m3db/m3x/server"
xsync "github.com/m3db/m3x/sync"
xtime "github.com/m3db/m3x/time"

"github.com/uber-go/tally"
)

const (
maxResourcePoolNameSize = 200
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe bump this to 256 for "power of 2-ness". Also IDs can get long in graphite land, heh.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I go higher than 256?

@richardartoul richardartoul changed the title [WIP] - Improve carbon ingestion performance Improve carbon ingestion performance Jan 30, 2019
robskillington
robskillington approved these changes Jan 30, 2019
View reviewed changes
Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than nits

@richardartoul richardartoul merged commit 876ae85 into master Jan 30, 2019
@justinjc justinjc deleted the ra/carbon-bench branch June 17, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robskillington robskillington robskillington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardartoul @robskillington