Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for advanced carbon ingestion configuration #1318

Merged
merged 53 commits into from
Jan 29, 2019

Conversation

richardartoul
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 27, 2019

Codecov Report

Merging #1318 into master will decrease coverage by 0.1%.
The diff coverage is 1.5%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1318     +/-   ##
========================================
- Coverage    70.8%   70.6%   -0.2%     
========================================
  Files         814     814             
  Lines       69227   69308     +81     
========================================
- Hits        49036   48992     -44     
- Misses      17057   17184    +127     
+ Partials     3134    3132      -2
Flag Coverage Δ
#aggregator 81.4% <ø> (ø) ⬆️
#cluster 85.6% <ø> (ø) ⬆️
#collector 78.4% <ø> (ø) ⬆️
#dbnode 80.9% <ø> (-0.1%) ⬇️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.6% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.8% <0%> (-0.1%) ⬇️
#msg 74.9% <ø> (ø) ⬆️
#query 64.3% <1.7%> (-0.6%) ⬇️
#x 75.9% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47c8a1b...960b57a. Read the comment docs.

@richardartoul richardartoul changed the title [WIP] Add support for advanced carbon ingestion configuration Add support for advanced carbon ingestion configuration Jan 28, 2019
Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than minor comments

@richardartoul richardartoul merged commit 8cddc48 into master Jan 29, 2019
@justinjc justinjc deleted the ra/carbon-regex branch June 17, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants