Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow msgpack library to allocate bufio.NewReader() and mmap summaries and bloom filter as files #1289

Merged
merged 9 commits into from
Jan 12, 2019

Conversation

richardartoul
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #1289 into master will decrease coverage by <.1%.
The diff coverage is 77.9%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1289     +/-   ##
========================================
- Coverage    70.6%   70.6%   -0.1%     
========================================
  Files         761     762      +1     
  Lines       64108   64138     +30     
========================================
+ Hits        45292   45299      +7     
- Misses      15885   15896     +11     
- Partials     2931    2943     +12
Flag Coverage Δ
#aggregator 81.6% <ø> (-0.1%) ⬇️
#cluster 85.6% <ø> (-0.2%) ⬇️
#collector 78.4% <ø> (ø) ⬆️
#dbnode 80.8% <77.9%> (-0.1%) ⬇️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.6% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 18.2% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 60.1% <ø> (ø) ⬆️
#x 75.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d56e81...8f0a6fc. Read the comment docs.

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richardartoul richardartoul merged commit beac725 into master Jan 12, 2019
robskillington pushed a commit that referenced this pull request Jan 28, 2019
@justinjc justinjc deleted the ra/mmap_file_and_summaries_fix branch June 17, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants