[query] Fix offset fetching too much data (#2260)

m3db · Apr 9, 2020 · 882ecb1 · 882ecb1
1 parent a5a84d0
commit 882ecb1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/query/plan/physical.go b/src/query/plan/physical.go
@@ -97,8 +97,8 @@ func (p PhysicalPlan) shiftTime() PhysicalPlan {
 		}
 
 		spec := boundOp.Bounds()
-		if spec.Offset+p.LookbackDuration > maxOffset {
-			maxOffset = spec.Offset + p.LookbackDuration
+		if p.LookbackDuration > maxOffset {
+			maxOffset = p.LookbackDuration
 		}
 
 		if spec.Range > maxRange {

diff --git a/src/query/plan/physical_test.go b/src/query/plan/physical_test.go
@@ -98,6 +98,6 @@ func TestShiftTime(t *testing.T) {
 	p, err = NewPhysicalPlan(lp, params)
 	require.NoError(t, err)
 	assert.Equal(t, params.Start.
-		Add(-1*(time.Minute+time.Hour+defaultLookbackDuration)), p.TimeSpec.Start,
+		Add(-1*(time.Hour+defaultLookbackDuration)), p.TimeSpec.Start,
 		"start time offset by fetch")
 }