Skip to content

Commit

Permalink
Fixup bug in matchRollupTarget exclude path
Browse files Browse the repository at this point in the history
  • Loading branch information
wesleyk committed Mar 4, 2021
1 parent a96ba0c commit 49ed219
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions src/metrics/rules/active_ruleset.go
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ func (as *activeRuleSet) matchRollupTarget(
nameTagName = as.tagsFilterOpts.NameTagKey
nameTagValue []byte
)
// switch rollupOp.
// Iterate through each tag, looking to match it with corresponding filter tags on the rule
matchTag:
for hasMoreTags := sortedTagIter.Next(); hasMoreTags; hasMoreTags = sortedTagIter.Next() {
tagName, tagVal := sortedTagIter.Current()
Expand Down Expand Up @@ -528,12 +528,6 @@ matchTag:
if opts.generateRollupID {
tagPairs = append(tagPairs, metricid.TagPair{Name: tagName, Value: tagVal})
}

// If one of the target tags is not found in the ID then does not
// need to be excluded.
if res > 0 {
break matchTag
}
}
}

Expand Down

0 comments on commit 49ed219

Please sign in to comment.