[query] Fix log statement that obscures error returned when failed to…

… write Prom response to client (#3638)
m3db · Jul 30, 2021 · 29722e7 · 29722e7
1 parent a984336
commit 29722e7
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/query/api/v1/handler/prom/read.go b/src/query/api/v1/handler/prom/read.go
@@ -196,13 +196,13 @@ func (h *readHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	err = Respond(w, &QueryData{
+	if err := Respond(w, &QueryData{
 		Result:     res.Value,
 		ResultType: res.Value.Type(),
-	}, res.Warnings)
-	if err != nil {
+	}, res.Warnings); err != nil {
 		h.logger.Error("error writing prom response",
-			zap.Error(res.Err), zap.String("query", params.Query),
+			zap.Error(err),
+			zap.String("query", params.Query),
 			zap.Bool("instant", h.opts.instant))
 	}
 }