Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update array sizes used in YOG parameterisation #50

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

jatkinson1000
Copy link
Member

@jatkinson1000 jatkinson1000 commented Nov 20, 2024

My resolve #47

Due to the way CAM uses part-full chunks to pass arrays (ncol <= pcol) the assumed sizes in YOG may not be consistent with sizes passed in from a cam state variable.

This has been gone through with some checks made.

  • Check this still runs OK in the TOGA II
  • Check if this improves the aquaplanet code

…ces of CAM variables to other subroutines, and use assumed shape everywhere possible.
@jatkinson1000
Copy link
Member Author

I have run in toga II and confirm that YOG_PREC and PRECC appear to remain unchanged:

image

@jatkinson1000
Copy link
Member Author

Previous version of YOG runniing f09 aquaplanet by @MarionBWeinzierl

3 Jan 0900
CLDLIQ at 609 hPa:

image

YOGDQ at 912 hPa:

image

@jatkinson1000
Copy link
Member Author

This branch of YOG runniing f09 aquaplanet by @jatkinson1000

3 Jan 0900
CLDLIQ at 609 hPa:

image

820 hPa

image

YOGDQ at 912 hPa

image

@jatkinson1000
Copy link
Member Author

Next look to do a 100 day run with the settings Paul sent.

@MarionBWeinzierl
Copy link
Collaborator

Next look to do a 100 day run with the settings Paul sent.

Everything fine with that run?

@jatkinson1000
Copy link
Member Author

Next look to do a 100 day run with the settings Paul sent.

Everything fine with that run?

So, given that this is clearly better than it was previously I was thinking we should merge now to provide everyone access to this fix from the main CAM-ML branch and then do the 100 day run plus other checks from there (as processing results and other analysis could take time). I think we said this yesterday. This would be #43 I guess.

Or would you prefer to do the run from here first?

@jatkinson1000 jatkinson1000 merged commit 625f3f3 into CAM-ML Nov 22, 2024
@jatkinson1000 jatkinson1000 deleted the array-sizes branch November 22, 2024 08:03
@omarjamil omarjamil mentioned this pull request Dec 3, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examine banding in Aquaplanet simulations
3 participants