Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Jenkins "WorkflowJob" job type support for jenni #29

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

m-sureshraj
Copy link
Owner

@m-sureshraj m-sureshraj commented Dec 19, 2019

  • Used nodejs builtin "URL" package to parse and validate URLs.
  • Display "Aborted" msg when initialization or confirmation query canceled by the user.
  • 100% unit tests coverage for jenkins.js

Breaking Change

  • Updated local config store structure. This will break the existing local configuration. User must reinitialize Jenni after updating to new Majaor version

closes #25

Copy link
Owner Author

@m-sureshraj m-sureshraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments.

* Used nodejs builtin "url" package to parse and validate urls.
* Display "Aborted" msg when initialization or confirmation query canceled by the user.
* Added 100% unit tests for jenkins.js

Breaking Change

* Updated local config store structure. This will break existing local configuration.
User must reinitialize Jenni after updating to new Majaor version
@m-sureshraj m-sureshraj force-pushed the incompatible-with-pipe-line-job branch from ef47627 to 3dfa900 Compare December 24, 2019 02:56
@m-sureshraj m-sureshraj changed the title fix: WIP feat: Added Jenkins "WorkflowJob" job type support for jenni Dec 24, 2019
@m-sureshraj m-sureshraj merged commit 24ddd66 into master Dec 24, 2019
@m-sureshraj m-sureshraj deleted the incompatible-with-pipe-line-job branch December 24, 2019 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with Jenkins Pipeline job
1 participant