Merge pull request #18 from m-sureshraj/linting-improvements

fix: Linting improvements

.eslintignore

@@ -0,0 +1,3 @@
+# /node_modules/* in the project root are ignored by default
+
+!.*.js

.eslintrc.js

@@ -1,16 +1,16 @@
 module.exports = {
   parserOptions: {
-    ecmaVersion: 2018
+    ecmaVersion: 2018,
   },
   env: {
     node: true,
-    es6: true
+    es6: true,
   },
   extends: 'eslint:recommended',
   plugins: ['prettier'],
   // 0: off, 1: warn, 2: error
   rules: {
     'prettier/prettier': 'error',
-    'no-console': 'off'
-  }
+    'no-console': 'off',
+  },
 };

lib/build-status.js

@@ -4,26 +4,26 @@ const { yellow, blue, red, green, magenta } = require('kleur');
 module.exports = {
   FAILED: {
     icon: red(figures.cross),
-    label: red('Failed')
+    label: red('Failed'),
   },
   SUCCESS: {
     icon: green(figures.tick),
-    label: green('Success')
+    label: green('Success'),
   },
   ABORTED: {
     icon: yellow(figures.warning),
-    label: yellow('Aborted')
+    label: yellow('Aborted'),
   },
   IN_PROGRESS: {
     icon: blue(figures.play),
-    label: blue('In Progress')
+    label: blue('In Progress'),
   },
   NOT_EXECUTED: {
     icon: magenta(figures.checkboxOn),
-    label: magenta('Not executed')
+    label: magenta('Not executed'),
   },
   UNSTABLE: {
     icon: yellow(figures.checkboxOff),
-    label: yellow('Unstable')
-  }
+    label: yellow('Unstable'),
+  },
 };

lib/cli-table.js

@@ -30,8 +30,8 @@ exports.printBuildHistory = function(builds = []) {
     colAligns: ['middle'],
     style: {
       head: ['cyan'],
-      compact: true
-    }
+      compact: true,
+    },
   });
   let status = null;
 
@@ -48,7 +48,7 @@ exports.printBuildHistory = function(builds = []) {
       build.name,
       status.label,
       printBuildStartedTime(build),
-      printBuildDuration(build)
+      printBuildDuration(build),
     ]);
   });
 
@@ -58,8 +58,8 @@ exports.printBuildHistory = function(builds = []) {
 exports.printConfig = function(config) {
   const table = new Table({
     style: {
-      head: ['cyan']
-    }
+      head: ['cyan'],
+    },
   });
 
   table.push(

lib/git-cmd.js

@@ -3,7 +3,7 @@ const { removeNewLine } = require('./util');
 
 exports.getCurrentBranchName = function() {
   const { stdout, stderr } = spawnSync('git', ['symbolic-ref', 'HEAD'], {
-    encoding: 'utf8'
+    encoding: 'utf8',
   });
 
   if (stderr) throw new Error(stderr);
@@ -13,7 +13,7 @@ exports.getCurrentBranchName = function() {
 
 exports.isGitRepository = function() {
   const { stdout } = spawnSync('git', ['rev-parse', '--is-inside-work-tree'], {
-    encoding: 'utf8'
+    encoding: 'utf8',
   });
 
   // error scenario `stderr` will be handled by the application
@@ -22,7 +22,7 @@ exports.isGitRepository = function() {
 
 exports.getGitRootDirPath = function() {
   const { stdout, stderr } = spawnSync('git', ['rev-parse', '--show-toplevel'], {
-    encoding: 'utf8'
+    encoding: 'utf8',
   });
 
   if (stderr) throw new Error(stderr);

lib/jenkins.js

@@ -33,7 +33,7 @@ function mapBuild(build) {
     durationMillis: build.durationMillis,
     startTimeMillis: build.startTimeMillis,
     endTimeMillis: build.endTimeMillis,
-    __meta__: build.__meta__
+    __meta__: build.__meta__,
   };
 }
 

lib/log.js

@@ -17,5 +17,5 @@ function logNetworkErrors(err) {
 
 module.exports = {
   debug,
-  logNetworkErrors
+  logNetworkErrors,
 };

lib/prompt.js

@@ -33,7 +33,7 @@ function getBaseJobQuestionConfig() {
     },
     name: 'job',
     message: 'Select current repo base job', // fixme - better message
-    choices: () => baseJobs
+    choices: () => baseJobs,
   };
 }
 
@@ -44,14 +44,14 @@ exports.requestJenkinsCredentials = function() {
       name: 'username',
       message: 'Jenkins username',
       validate: val => val.trim() !== '',
-      format: val => val.trim()
+      format: val => val.trim(),
     },
     {
       type: 'text',
       name: 'token',
       message: 'Jenkins api-token',
       validate: val => val.trim() !== '',
-      format: val => val.trim()
+      format: val => val.trim(),
     },
     {
       type: 'text',
@@ -66,9 +66,9 @@ exports.requestJenkinsCredentials = function() {
         }
 
         return val;
-      }
+      },
     },
-    getBaseJobQuestionConfig()
+    getBaseJobQuestionConfig(),
   ];
 
   // todo: show banner message about jenkins credentials
@@ -81,7 +81,7 @@ exports.askConfirmation = function() {
     type: 'confirm',
     name: 'confirmation',
     message: 'Are you sure you want to save this configuration?',
-    initial: true
+    initial: true,
   };
 
   return prompts(question);

lib/util.js

@@ -10,7 +10,7 @@ const months = [
   'Sep',
   'Oct',
   'Nov',
-  'Dec'
+  'Dec',
 ];
 
 exports.removeNewLine = function(str) {

package.json

@@ -20,7 +20,7 @@
     }
   },
   "lint-staged": {
-    "**/*.js": [
+    "*.js": [
       "npm run lint-fix",
       "git add"
     ]

prettier.config.js

@@ -1,11 +1,11 @@
 module.exports = {
   printWidth: 90,
-  trailingComma: 'none',
+  trailingComma: 'es5',
   tabWidth: 2,
   useTabs: false,
   semi: true,
   singleQuote: true,
   bracketSpacing: true,
   arrowParens: 'avoid',
-  endOfLine: 'lf'
+  endOfLine: 'lf',
 };

src/commands/config.js

@@ -67,7 +67,7 @@ module.exports = async function config(options = {}) {
     ...(username && { username }),
     ...(token && { token }),
     ...(url && { url }),
-    ...(job && { job })
+    ...(job && { job }),
   };
 
   // if options passed update configuration

src/commands/open.js

@@ -4,7 +4,7 @@ const Conf = require('conf');
 const {
   isGitRepository,
   getGitRootDirPath,
-  getCurrentBranchName
+  getCurrentBranchName,
 } = require('../../lib/git-cmd');
 const { getBranchJobLink } = require('../../lib/jenkins');
 const { debug } = require('../../lib/log');

src/commands/status.js

@@ -5,7 +5,7 @@ const terminalLink = require('terminal-link');
 const {
   getCurrentBranchName,
   isGitRepository,
-  getGitRootDirPath
+  getGitRootDirPath,
 } = require('../../lib/git-cmd');
 const { getBranchBuildHistory, getBranchJobLink } = require('../../lib/jenkins');
 const { printBuildHistory } = require('../../lib/cli-table');