Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support toHaveReceivedAnyCommand matcher #202

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat: support toHaveReceivedAnyCommand matcher #202

merged 1 commit into from
Jan 15, 2024

Conversation

yaronya
Copy link
Contributor

@yaronya yaronya commented Jan 4, 2024

Resolves #201

@yaronya yaronya changed the title Add support for toHaveReceivedAnyCommand matcher feat: Add support for toHaveReceivedAnyCommand matcher Jan 4, 2024
@yaronya yaronya changed the title feat: Add support for toHaveReceivedAnyCommand matcher feat: add support for toHaveReceivedAnyCommand matcher Jan 4, 2024
@yaronya yaronya changed the title feat: add support for toHaveReceivedAnyCommand matcher feat: support for toHaveReceivedAnyCommand matcher Jan 4, 2024
@yaronya yaronya changed the title feat: support for toHaveReceivedAnyCommand matcher feat: support toHaveReceivedAnyCommand matcher Jan 4, 2024
@yaronya yaronya changed the title feat: support toHaveReceivedAnyCommand matcher feat: support toHaveReceivedAnyCommand matcher Jan 4, 2024
@yaronya yaronya force-pushed the main branch 2 times, most recently from 15d0767 to de35cb8 Compare January 4, 2024 12:28
@m-radzikowski
Copy link
Owner

Thanks for the PR!

Please take a look at lint errors. The logic is fine 👍

@yaronya
Copy link
Contributor Author

yaronya commented Jan 4, 2024

Thanks for the PR!

Please take a look at lint errors. The logic is fine 👍

Thanks @m-radzikowski
Note that I disabled an eslint rule in the spec file for one line due to its explicit check for no any types, as I wanted to use the local AwsCommand type 💪

@yaronya yaronya requested a review from m-radzikowski January 4, 2024 18:30
@yaronya
Copy link
Contributor Author

yaronya commented Jan 15, 2024

Hey @m-radzikowski
Any chance this can be merged and released soon? was looking forward to use it in my code :)

@m-radzikowski m-radzikowski merged commit ba5eedb into m-radzikowski:main Jan 15, 2024
2 checks passed
@m-radzikowski
Copy link
Owner

Released in v3.1.0-beta.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-radzikowski m-radzikowski Awaiting requested review from m-radzikowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support toHaveReceivedAnyCommand
2 participants
@yaronya @m-radzikowski