Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master: add an argument to set an experiment subdirectory #1767

Merged

Conversation

fanmingyu212
Copy link
Contributor

Signed-off-by: Mingyu Fan [email protected]

ARTIQ Pull Request

Description of Changes

Adds an argument to artiq_master config to set a sub-directory when scanning for experiments.

When an experiment sub-directory is specified, the root in the experiment explorer GUI is set to the sub-directory. I tested running experiments through this GUI.

Related Issue

Closes #1766

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Steps (Choose relevant, delete irrelevant before submitting)

All Pull Requests

  • Use correct spelling and grammar.
  • Update RELEASE_NOTES.rst if there are noteworthy changes, especially if there are changes to existing APIs.
  • Close/update issues.
  • Check the copyright situation of your changes and sign off your patches (git commit --signoff, see copyright).

Code Changes

  • Run flake8 to check code style (follow PEP-8 style). flake8 has issues with parsing Migen/gateware code, ignore as necessary.
  • Test your changes or have someone test them. Mention what was tested and how.

Git Logistics

  • Split your contribution into logically separate changes (git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.
  • Write short & meaningful commit messages. Review each commit for messages (git show). Format:
    topic: description. < 50 characters total.
    
    Longer description. < 70 characters per line
    

Licensing

See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.

@sbourdeauducq sbourdeauducq merged commit 178a86b into m-labs:master Oct 15, 2021
@fanmingyu212 fanmingyu212 deleted the mf/artiq_master_experiment_subdir branch October 15, 2021 08:55
@b-bondurant b-bondurant mentioned this pull request Dec 16, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slow scan when repository contains lots of non-experiment Python files
2 participants