Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set batch priority on dedup and join #412

Merged
merged 4 commits into from
Oct 17, 2022

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Oct 14, 2022

This change adds QueryConfig.Priority for Dedup and Join jobs created by gardener using "Batch" priority. This change should avoid quota limits for interactive jobs recently seen in #410.

Fixes:


This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Oct 14, 2022

Pull Request Test Coverage Report for Build 3588

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 77.771%

Totals Coverage Status
Change from base Build 3581: 0.1%
Covered Lines: 1242
Relevant Lines: 1597

💛 - Coveralls

Copy link
Contributor

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @stephen-soltesz)


cloud/bq/ops.go line 120 at r2 (raw file):

			Q:      qs,
			DryRun: dryRun,
			// Perform Join as a batch job to avoid quota limits for interactive jobs.

I think you mean Dedup here.


cloud/bq/ops_test.go line 119 at r2 (raw file):

			}
			if cfg.(*bigquery.QueryConfig).Priority != bigquery.BatchPriority {
				t.Errorf("TestValidateQueries() Dedup job priority is not Batch: %v", bigquery.BatchPriority)

And Join here.

@stephen-soltesz stephen-soltesz merged commit e32dae1 into main Oct 17, 2022
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-batch-jobs branch October 17, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants