reverse pytest-mark-no-parenthese and pytest-fixture-no-parentheses #272
Comments
|
I understand that the default behaviour of |
|
from my pov thats a problem just for my usages i'd have to add that rule to >100 git repos to ensure consistency or avoid the tool ruff currently mirrors the behaviour but plans to witch around |
May I clarify what you mean by 'adding the rule'?
Is there a corresponding issue in ruff? |
|
So far none of the git repos where I intend to add this has a costom flake8 config, I'm relatively strictly against adding one as it's a starting point that allows people inconsistency There's not yet a issue in ruff do for the actual detail They plan a larger reorganize off the rules away from replicating other ecosystem plugins and discussions about this issue there indicates that they would also prefer a default rule that's the reverse of the replica of this plugin |
|
I think we need to make this breaking change. The default configuration should promote the best variant. Also it not a big breaking change because it's configurable. |
|
I've just released v2.0.0 with this change. |
## Summary This patch inverts the defaults for [pytest-fixture-incorrect-parentheses-style (PT001)](https://docs.astral.sh/ruff/rules/pytest-fixture-incorrect-parentheses-style/) and [pytest-incorrect-mark-parentheses-style (PT003)](https://docs.astral.sh/ruff/rules/pytest-incorrect-mark-parentheses-style/) to prefer dropping superfluous parentheses. Presently, Ruff defaults to adding superfluous parentheses on pytest mark and fixture decorators for documented purpose of consistency; for example, ```diff import pytest [email protected] [email protected]() def test_bar(): ... ``` This behaviour is counter to the official pytest recommendation and diverges from the flake8-pytest-style plugin as of version 2.0.0 (see m-burst/flake8-pytest-style#272). Seeing as either default satisfies the documented benefit of consistency across a codebase, it makes sense to change the behaviour to be consistent with pytest and the flake8 plugin as well. This change is breaking, so is gated behind preview (at least under my understanding of Ruff versioning). The implementation of this gating feature is a bit hacky, but seemed to be the least disruptive solution without performing invasive surgery on the `#[option()]` macro. Related to #8796. ### Caveat Whilst updating the documentation, I sought to reference the pytest recommendation to drop superfluous parentheses, but couldn't find any official instruction beyond it being a revealed preference within the pytest documentation code examples (as well as the linked issues from a core pytest developer). Thus, the wording of the preference is deliberately timid; it's to cohere with pytest rather than follow an explicit guidance. ## Test Plan `cargo nextest run` I also ran ```sh cargo run -p ruff -- check crates/ruff_linter/resources/test/fixtures/flake8_pytest_style/PT001.py --no-cache --diff --select PT001 ``` and compared against it with `--preview` to verify that the default does change under preview (I also repeated this with `echo '[tool.ruff]\npreview = true' > pyproject.toml` to verify that it works with a configuration file). --------- Co-authored-by: Charlie Marsh <[email protected]>
the general suggestion we use in the pytest docs and in most related projects is dropping the empty parentheses if feasible
The text was updated successfully, but these errors were encountered: