Improved sentence segmentation based on word timestamps #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves sentence segmentation by handling long sentences and enforcing time-based breaks. Previously, all words between punctuation marks were grouped into a single segment, regardless of duration. This could lead to extremely long segments (60-80 seconds) which is problematic for many applications.
m-bain
reviewed
Jan 11, 2025
| gap_duration = current_word_start - prev_word_end | ||
|
|
||
| if gap_duration >= gap_threshold: | ||
| if current_segment: # Boş segment eklemeyi önle |
There was a problem hiding this comment.
Suggested change
| if current_segment: # Boş segment eklemeyi önle | |
| if current_segment: # Prevent adding empty segments |
m-bain
reviewed
Jan 11, 2025
| if current_segment: # Boş segment eklemeyi önle | ||
| segments.append(current_segment) | ||
| current_segment = [word] | ||
| els |
|
I feel like these changes should be in the subtitle writer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves sentence segmentation by handling long sentences and enforcing time-based breaks. Previously, all words between punctuation marks were grouped into a single segment, regardless of duration. This could lead to extremely long segments (60-80 seconds) which is problematic for many applications.